Make OFF run-directory initialization OS-agnostic on Windows via pathlib#30
Draft
Copilot wants to merge 2 commits into
Draft
Make OFF run-directory initialization OS-agnostic on Windows via pathlib#30Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix running OFF on Windows by using os.getcwd()
Make OFF run-directory initialization OS-agnostic on Windows via pathlib
Jun 19, 2026
ivovs-tud
requested changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OFF aborted on Windows when
OFF_PATHwas unset because directory fallback logic depended onos.environ["PWD"](Unix-specific). This change switches fallback resolution topathlib+Path.cwd()so run-directory initialization works consistently across platforms.Root path resolution in
OFF.__dir_init__Pathcomposition.data folder→OFF_PATH/runs→ cwd-based fallback.03_Codespecial case usingPath.cwd().name == "03_Code"andcwd.parent / "runs".Directory and root tracking cleanup
[:-len("runs/")]) withroot_path.parent.sim_dirconstruction viaroot_path / f"off_run_{run_id}".Path(...).mkdir(parents=True, exist_ok=True).Focused regression coverage
OFF_PATHis missing:<cwd>/runs03_Codefallback to<parent>/runsPWDto an unrelated value to verify logic no longer depends on it.